Conversation
…ure/member_detail
Roy-wonji
approved these changes
Aug 12, 2025
| var body: some View { | ||
| VStack(spacing: 20) { | ||
| MemberProfileView(profile: MemberProfile()) | ||
| ScrollView { |
Contributor
There was a problem hiding this comment.
굳이 vstack 안쓰고 내부안에 스크롤 할 방식을 선택 할수 있습니다
| } | ||
| } | ||
|
|
||
| struct StrengthsView: View { |
Contributor
There was a problem hiding this comment.
@minneee 이건 뷰를 분리 하는거 어떨가요 ??
아님 큰 뷰가 아니면 viewbuilder 로 바꾸는거 어떨까요 ?
| } | ||
| } | ||
|
|
||
| struct introductionView: View { |
|
|
||
| import SwiftUI | ||
|
|
||
| struct MemberProfile { |
Peter1119
approved these changes
Aug 12, 2025
Comment on lines
+164
to
+185
| struct CardStyle: ViewModifier { | ||
| func body(content: Content) -> some View { | ||
| content | ||
| .padding(15) | ||
| .frame(maxWidth: .infinity, alignment: .leading) | ||
| .background( | ||
| RoundedRectangle(cornerRadius: 16) | ||
| .fill(.staticWhite) | ||
| ) | ||
| .overlay( | ||
| RoundedRectangle(cornerRadius: 16) | ||
| .stroke(.borderInactive, lineWidth: 0.5) | ||
| ) | ||
| .shadow(color: .shadowDefault, radius: 3, x: 0, y: 1) | ||
| } | ||
| } | ||
|
|
||
| extension View { | ||
| public func cardStyle() -> some View { | ||
| modifier(CardStyle()) | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
오 card style modifier 좋네요 ~! 이건 design system 에 들어가도 좋을 것 같아요
Comment on lines
+123
to
+129
| VStack { | ||
| Text(profile.collabStyle) | ||
| .pretendardFont(family: .Regular, size: 13) | ||
| .foregroundStyle(.textSecondary100) | ||
| .lineSpacing(5) | ||
| } | ||
| .cardStyle() |
Collaborator
There was a problem hiding this comment.
이거 VStack으로 감싸지 않아도 되지 않을까요 ??
Comment on lines
+81
to
+87
| VStack { | ||
| Text(profile.introduction) | ||
| .pretendardFont(family: .Regular, size: 13) | ||
| .foregroundStyle(.textSecondary100) | ||
| .lineSpacing(5) | ||
| } | ||
| .cardStyle() |
Collaborator
There was a problem hiding this comment.
여기도 VStack으로 감싸지 않아도 되지 않을까 싶습니다 ~!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ 작업 내용
📝 참고 사항
Key Changes 🔥 (주요 구현/변경 사항)
Checklist